feat: Add glob support for package name in matchspec #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelzw
commented
Oct 10, 2025
| let base_url = repo_data.info.as_ref().and_then(|i| i.base_url.as_deref()); | ||
| for (package_name, specs) in &spec.into_iter().chunk_by(|spec| spec.borrow().name.clone()) { | ||
| let grouped_specs = specs.into_iter().collect::<Vec<_>>(); | ||
| // TODO: support glob/regex package names |
|
@baszalmstra ready for review! once this is merged, i can make the config for conda-mirror a bit easier to use! |
wolfv
reviewed
Oct 27, 2025
wolfv
requested changes
Oct 27, 2025
crates/rattler_solve/tests/snapshots/backends__resolvo__issue_717.snap
Outdated
Show resolved
Hide resolved
wolfv
reviewed
Oct 27, 2025
| MatchSpec::from_nameless(NamelessMatchSpec::from_str(">=12", Strict).unwrap(), None); | ||
| assert!(!spec.is_virtual()); | ||
|
|
||
| let spec = MatchSpec::from_str("__virtual_glob*", Strict).unwrap(); |
There was a problem hiding this comment.
Now that I see this I wonder if we should add a third mode for the parsing or a new constrcutor because I would like to validate at parsing in rattler-build that we get exact matchspecs. Maybe something like from_str_wiht_matcher or Strict, Lenient, StrictWithMatcher, LenientWithMatcher ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
for
rattler::install,rattler_solveandrattler_repodata_gatewayi didn't support globbed matchspecs to keep this pr manageable.instead, i behave exactly like when we had a nameless matchspec there (i.e. either skip or panic)
i don't think supporting them in
rattler_solvemakes much sense as there are no packages that have globbed packages as dependencies anyway.for
rattler_repodata_gateway, i do see some nice use cases (for examplepixi search jupyter*which is currently handled in a custom manner). let's move this to another pr: #1723